[tor-bugs] #12716 [meek]: Make meek-client-torbrower take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrower take the firefox command as a parameter
------------------------+-----------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------

Comment (by dcf):

 I'm not in love with any idea that has been proposed so far. The double-
 dash idea from comment:1 and comment:5 is workable, but I think we would
 grow to dislike it.

 The `sh -c exec "$1"` idea in comment:5 is about 1.2× as crazy I usually
 like solutions to be :) But it's headed in a good direction. What
 infinity0 wrote "we can instead write a wrapper shell script that calls
 firefox" is what we should do, I think.

 Here's what I'm thinking:
 {{{
 meek-client-helper --helper ./path/to/helper.sh -- ./path/to/meek-client
 }}}
 The --helper option is the program that runs the helper. However the catch
 is that you only get to specify the name of a single file to run: no
 arguments, no shell expansion, and no string splitting. Anything that the
 helper needs, for example the path to the profile, or a call to realpath,
 has to be encoded into the script.

 In the browser bundle, we'll have a different helper script for each OS,
 corresponding to the current [https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/0236be729748b3a73e606198a73a68b729379d6e:/meek-
 client-torbrowser/linux.go linux.go], [https://gitweb.torproject.org
 /pluggable-
 transports/meek.git/blob/0236be729748b3a73e606198a73a68b729379d6e:/meek-
 client-torbrowser/mac.go mac.go], and [https://gitweb.torproject.org
 /pluggable-
 transports/meek.git/blob/0236be729748b3a73e606198a73a68b729379d6e:/meek-
 client-torbrowser/windows.go windows.go] in meek-client-torbrowser. On
 windows we can use, I don't know, a batch file or something, or in the
 worst case yet another compiled program. The customization for Debian will
 be just one Debian-specific shell script.

 The reason for having a --helper option instead of having it being implied
 by position is to leave room for other options in meek-client-helper like
 --log. It keeps the usual meaning of --; i.e., everything before --
 "belongs" to meek-client-helper and everything after is a non-option.
 Omitting the --helper option could mean to just run meek-client directly
 without a helper (which is sometimes useful).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online