[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_revision
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237
   Resolution:           |  026-triaged-1
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Oh.  Also, make sure you try compiling with --enable-gcc-warnings , and
 fix all the warnings this finds.  (I think there's one in the unused arg
 of test_nodelist_node_is_dir().)

 In the tests:
   * `+  memset(rs3->status.descriptor_digest, 181818, DIGEST_LEN)` makes
 no sense; the second argument to memset needs to be a byte.
   * The new test code seems to be substantially similar to other tests in
 test_dir.  Can the common code be factored out?  Copy-and-paste is a bad
 practice in programming; that's what we have functions for.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online