[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237
   Resolution:           |  026-triaged-1
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Reviewing from scratch, with dgoulet:

 Less important, but should get fixed:
  * I think the log_info(LD_BUG) should be a log_warn ?  Otherwise, we'll
 never see it.
  * Isn't there a define for the length of the output of tor_addr_to_str?
 Also, doesn't it always nul-terminate?
  * `#endif //TOR_UNIT_TESTING` should refer to TOR_UNIT_TESTS instead.
  * If we use a switch in networkstatus_set_current_consensus_from_ns() ,
 then we'll get a warning if we forget to add more cases in the future.
  * current_ns_consensus = NULL and current_md_consensus=NULL are both
 redundant.
  * Why return -2 instead of -1 ?

 More important:
  * We need to look at something like decide_to_advertise_dirport() [maybe
 a modified version of it] when deciding whether to set tunneled-dir-
 server.  The bandwidthrate stuff is particularly important.
  * The directory_fetches_from_authorities() function should also return 0
 if we decided not to set dir_port or tunneled-dir-requests.  Otherwise
 low-bandwidth ORs will hit the authorities rather than the caches, which
 is not what we want.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online