[tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

[Tor Bug Tracker & Wiki]

#13339: Merge GSoC project - Consensus Diffs
-----------------------------+-------------------------------------------
     Reporter:  mvdan        |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  major        |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  gsoc merge tor-client prop140
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------------

Comment (by tom):

 I didn't look very comprehensively, and just at consdiff.  I could be
 missing context here, but it seems like there are some scenarios where
 consdiff_gen_diff would not free ed_diff?  (I'm looking at
 https://github.com/mvdan/tor/blob/consdiff-5/src/or/consdiff.c#L737 )

 1) gen_ed_diff succeeds but apply_ed_diff fails
 2) gen_ed_diff succeeds, apply_ed_diff succeeds, but the "the generated ed
 diff did not generate the target consensus successfully"

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online