[tor-bugs] #10007 [Torsocks]: Code review of torsocks 2.x

[Tor Bug Tracker & Wiki]

#10007: Code review of torsocks 2.x
-----------------------------+---------------------
     Reporter:  dgoulet      |      Owner:  ioerror
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Torsocks     |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+---------------------

Comment (by anon):

 Review curtailed; ah Paris...

 Initial review showed nothing defect or vulnerability wise of concern. I
 had some greps and seds that reduced a lot of porting/refactoring chaf I
 felt like not looking at (in the diff).

 My suggestions were all of the widest portability and conservative code
 practice suggestion variety.

 As for "will this review happen", not by anon. If someone else is willing
 to do an audit, that would be great.

 As for closing out ticket, I stand by my prior comments that 2.0 is
 leagues better.
 That initial review (read: incomplete, but not totally useless) is
 positive and my feedback oriented around improvement rather than defect
 correction.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10007#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online