[tor-bugs] #13214 [Tor]: HS clients don't validate descriptor-id returned by HSDir

[Tor Bug Tracker & Wiki]

#13214: HS clients don't validate descriptor-id returned by HSDir
-------------------------+------------------------------------------
     Reporter:  special  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  SponsorR tor-hs 025-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+------------------------------------------

Comment (by special):

 {{{
 +  if (base32_decode(want_desc_id, sizeof(want_desc_id),
 +                    desc_id_base32, strlen(desc_id_base32)) !=
 DIGEST_LEN) {
 }}}

 base32_decode returns 0 on success.

 Otherwise, it looks good to me. After fixing that, this branch works as a
 client.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13214#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online