[tor-bugs] #11216 [BridgeDB]: BridgeDB is parsing PTs from `cached-extrainfo*` files cumulatively
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat May 24 23:39:46 UTC 2014
#11216: BridgeDB is parsing PTs from `cached-extrainfo*` files cumulatively
-------------------------+-------------------------------------------------
Reporter: isis | Owner: isis
Type: defect | Status: new
Priority: | Milestone:
critical | Version:
Component: | Keywords: bridgedb-0.2.x, metrics, bridgedb-
BridgeDB | parsers
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Changes (by isis):
* keywords: bridgedb-0.1.6, metrics, bridgedb-parsers => bridgedb-0.2.x,
metrics, bridgedb-parsers
Comment:
The relevant parts of the code are
[https://gitweb.torproject.org/bridgedb.git/blob/refs/heads/develop:/lib/bridgedb/Main.py#l114
here] and
[https://gitweb.torproject.org/bridgedb.git/blob/refs/heads/develop:/lib/bridgedb/Bridges.py#l573
here]. These are very old, very unmaintained (I've not gotten around to
refactoring them, nor creating unittests for them yet) bits of BridgeDB's
code.
Basically, I don't especially care if these functions are kept. I would
prefer them to be rewritten entirely, but whatever fixes this bug is fine
by me. If someone were to go the complete rewrite route for fixing this
bug, then 9000+ bonus points if you do any of the following:
1. Refactor the extra-info descriptor parser using
[https://stem.torproject.org Stem].
2. Write some unittests for the thing.
Though neither are necessary and all patches welcome.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11216#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list