[tor-bugs] #12064 [Tor]: Tor should be able to read all files it creates when Sandbox enabled.

[Tor Bug Tracker & Wiki]

#12064: Tor should be able to read all files it creates when Sandbox enabled.
---------------------------+--------------------------------
     Reporter:  alphawolf  |      Owner:
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor        |    Version:  Tor: 0.2.5.4-alpha
   Resolution:             |   Keywords:  sandbox
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+--------------------------------

Comment (by nickm):

 Replying to [ticket:12064 alphawolf]:
 > After #12035 and #12041, I realized that there are probably a lot of
 files that tor creates that are not specifically allowed in the sandbox.
 I've not tested all of these to make sure there is actually a bug, but
 these are the files listed in the [https://www.torproject.org/docs/tor-
 manual-dev.html.en torrc documentation] that I don't see mentioned in
 `sandbox_cfg_allow_open_filename_array()` or elsewhere in `src/or/main.c`.
 >
 > Part 1 (Stuff I have a patch for):
 > {{{
 > DataDirectory/status/entry-stats
 > DataDirectory/status/exit-stats
 > DataDirectory/status/buffer-stats
 > DataDirectory/status/conn-stats
 > }}}

 You mean "stats", not "status"?

 > Part 2 (Marked obsolete in docs... patch not necessary?):
 > {{{
 > DataDirectory/cached-routers and cached-routers.new
 > DataDirectory/bw_accounting
 > }}}

 Correct; these are not used any longer.

 > Part 3 (Stuff I'm unsure of):
 > {{{
 > DataDirectory/control_auth_cookie
 > DataDirectory/approved-routers
 > }}}

 control_auth_cookie can be overridden with CookieAuthFile.  See (and maybe
 use?) get_cookie_file() in control.c.  If that function is going to become
 non-static however, it probably needs a better name.

 Also see get_ext_or_auth_cookie_file_name().

 The approved-routers file should be readable too.

 > Part 4 (Hidden Directory Files - tested, broken because unable to read
 private_key):
 > {{{
 > HiddenServiceDirectory/hostname
 > HiddenServiceDirectory/private_key
 > HiddenServiceDirectory/client_keys
 > }}}
 >
 > A patch for part 1 is inbound (based off the fixes for the previous
 bugs).  Someone else will need to write any patches for parts 2 - 4.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12064#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online