[tor-bugs] #11783 [TorBrowserButton]: Torbutton: Unexpected error on new identity: TypeError: b.webProgress is undefined

[Tor Bug Tracker & Wiki]

#11783: Torbutton: Unexpected error on new identity: TypeError: b.webProgress is
undefined
---------------------------------+-----------------------------------------
     Reporter:  cypherpunks      |      Owner:  mikeperry
         Type:  defect           |     Status:  needs_review
     Priority:  normal           |  Milestone:
    Component:                   |    Version:
  TorBrowserButton               |   Keywords:  tbb-newnym, MikePerry201405
   Resolution:                   |  Parent ID:
Actual Points:                   |
       Points:                   |
---------------------------------+-----------------------------------------

Comment (by gk):

 Replying to [comment:31 cypherpunks]:
 > > but clicking on the menuitem n times is executing the function, which
 is bound to it, n times (approximately; it depends on how fast you and
 probably your computer are)
 > You can't to click twice on the same menu item, oncommand should be
 called only once or menu should never be destroyed. For menu popups only 1
 click is allowed, all next is state of art.
 >
 > {{{
 > document.getElementById("torbutton-new-identity").disabled = false;
 > }}}
 > Why to re-enable it on exception? What purpose? Those element doesn't
 exist after oncommand finished. You can't to keep menu on exception too.
 Element recreated on every new menu popup with default state.

 Ah, right. That's one episode in the "Think Once, Commit Twice" saga...
 bug_11783_v2 in my repo is the new hotness.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11783#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online