[tor-bugs] #10819 [Firefox Patch Issues]: Create preference for DOM storage isolation and image cache isolation

[Tor Bug Tracker & Wiki]

#10819: Create preference for DOM storage isolation and image cache isolation
-------------------------------------+-------------------------------------
     Reporter:  mikeperry            |      Owner:  mikeperry
         Type:  enhancement          |     Status:  new
     Priority:  normal               |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-mozilla-merge,
   Resolution:                       |  interview, MikePerry201405R
Actual Points:                       |  Parent ID:  #10820
       Points:                       |
-------------------------------------+-------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:8 mcs]:
 > Mike asked Kathy Brade and me to review this patch (he is reviewing it
 as well).

 Thanks!

 > What is the effect on the other subsystems?  If first party isolation is
 disabled, we probably want everything to work just like it does in
 Firefox.  For imageLoader, it looks like values generated by GetCacheKey()
 will still be different than in Firefox.

 That's true. I've changed GetCacheKey so that it returns the bare image
 URI spec, just as expected in standard Firefox.

 > For DOM storage, it looks like using a NULL URI will return everything
 to the original Firefox behavior.  But please verify if you have not
 already done so.

 Yes, I checked again and I believe nullptr URI behavior is the same as
 standard Firefox.

 > Unless is needs to be called from elsewhere,
 IsFirstPartyIsolationActive() should be a private method.

 Fixed.

 > IsFirstPartyIsolationActive() should avoid getting the channel and
 checking for private browsing mode if the pref value is 0 or 2.

 Fixed.

 > ThirdPartyUtil::GetFirstPartyIsolationURI() should check the return
 value from IsFirstPartyIsolationActive.  Also, please initialize
 isolationActive when it is declared.  Note that if
 IsFirstPartyIsolationActive() is converted to a private method that
 returns a bool, these issues disappear.

 Done.

 (I posted a new version of the patch.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10819#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online