[tor-bugs] #11638 [Tor]: Backport raising of #9731 fixes.

[Tor Bug Tracker & Wiki]

#11638: Backport raising of #9731 fixes.
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  robgjansen             |     Status:  needs_review
         Type:  defect   |  Milestone:  Tor: 0.2.4.x-final
     Priority:  normal   |    Version:  Tor: 0.2.4.21
    Component:  Tor      |   Keywords:  tor-relay, shadow, infinite, loops,
   Resolution:           |  nickm-backport-02422, arma-backport-02422
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by robgjansen):

 Replying to [comment:8 nickm]:
 > Rob, those patches don't apply cleanly to maint-0.2.4.  Have you tested
 0.2.4 plus these patches?  If so, do you have a copy of the patches as you
 backported them?
 >

 I did not apply those directly, and do not have a patch. I just noticed
 that following those commits, things starting working again.

 > If not, I made a branch as "bug11638_024" where I tried to backport the
 full version of #9731 from 0.2.5.x as modified by those patches.  Will you
 have a chance to try it out and see if it works for you?
 >

 An experiment is running now. If things go well, it should finish in ~6
 hours, and I'll post back here with the results.

 > > b) we already backported most of this patch but missed these parts.
 >
 > We actually didn't backport most of 9731; we backported a conservative
 version in 0.2.4.18-rc where we checked for `conn->type ==
 CONN_TYPE_CPUWORKER`.  The tickets above move the the checks to the start
 of the function, but rely on an earlier commit that made the check into
 `!connection_is_rate_limited(conn)`.

 Right, I noticed multiple sets of commits as well. I think the first set
 caused the infinite loops, and the last set fixed them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11638#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online