[tor-bugs] #11683 [Tor]: Stop caching extra-info documents on directory mirrors
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon May 5 15:22:23 UTC 2014
#11683: Stop caching extra-info documents on directory mirrors
-----------------------------+--------------------------
Reporter: karsten | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.???
Component: Tor | Version:
Resolution: | Keywords: tor-relay
Actual Points: | Parent ID:
Points: |
-----------------------------+--------------------------
Comment (by karsten):
You mean something like this?
{{{
diff --git a/src/or/router.c b/src/or/router.c
index 86cefc9..5ecf065 100755
--- a/src/or/router.c
+++ b/src/or/router.c
@@ -2370,7 +2370,7 @@ router_dump_router_to_string(routerinfo_t *router,
has_extra_info_digest ? "extra-info-digest " : "",
has_extra_info_digest ? extra_info_digest : "",
has_extra_info_digest ? "\n" : "",
- options->DownloadExtraInfo ? "caches-extra-info\n" : "",
+ options->V3AuthoritativeDir ? "caches-extra-info\n" : "",
onion_pkey, identity_pkey,
family_line,
we_are_hibernating() ? "hibernating 1\n" : "",
}}}
(I can turn this into a real commit with changes file if this is the patch
you want to apply.)
This patch is certainly simpler. But it has the downside that directory
authorities will have to include "caches-extra-info" forever, or at least
until we teach clients not to rely on that line plus two or three release
cycles. (That's why I suggested 0.2.5 above, to save a release cycle.)
If either patch is too hot for 0.2.5, how about we defer until 0.2.6?
Nothing urgent here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11683#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list