[tor-bugs] #11296 [Tor]: Missing include breaks build of tor-fw-helper in 0.2.5.3

[Tor Bug Tracker & Wiki]

#11296: Missing include breaks build of tor-fw-helper in 0.2.5.3
------------------------+--------------------------------
     Reporter:  hiviah  |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.5.3-alpha
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by hiviah):

 Yes, it fixes the problem with building tor-fw-helper.

 The build breaks on generating documentation, which I can't quite
 understand how it can be affected by the added include from patch (this
 does not occur without --enable-upnp):
 {{{
   GEN    doc/tor-resolve.1
   GEN    doc/torify.1
 config.status: error: cannot find input file: doc/torify.1.in
 make[1]: *** [doc/torify.1] Error 1
 make[1]: Leaving directory `/home/ondro/tmp/tor.clean'
 make: *** [all] Error 2
 }}}

 I tried to randomly insert the include at various places, but still get
 the failure with documentation generation.

 When crosscompiling using openwrt buildroot, it gives wholly different and
 more confusing error about automake-1.13 missing, just after applying the
 bug11296 branch patch. I'll try looking into a bit more, but currently I
 can't see a specific cause for it right now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11296#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online