[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

[Tor Bug Tracker & Wiki]

#7472: Audit all calls to connection_mark_for_close()
------------------------+--------------------------------
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.5-alpha
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 * connection_handle_write_impl():
    - I think it's a bug to call connection_mark_for_close() on an orconn
 after getsockopt() fails.  This is all in an if
 (connection_state_is_connecting()), so I think there should be a test for
 orconn and connection_or_connect_failed() rather than
 connection_mark_for_close() in that case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online