[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 24 22:15:38 UTC 2014

#7472: Audit all calls to connection_mark_for_close()
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor:
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |

Comment (by andrea):

 * connection_handle_read_cb() and connection_handle_write_cb():
    - Bufferevents don't quite work anyway, so testing or further
 investigation is difficult here.
    - I believe the connection_handle_read_cb() case is safe because
 connection_process_inbuf() will always correctly mark an orconn and notify
 the controlling channel when it fails.
    - The connection_handle_write_cb() case is safe because
 connection_flushed_some() always calls connection_or_flushed_some() on an
 orconn, and connection_or_flushed_some() never returns an error.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list