[tor-bugs] #8966 [Tor]: contrib/ directory should be cleaned up

[Tor Bug Tracker & Wiki]

#8966: contrib/ directory should be cleaned up
-------------------------+--------------------------------
     Reporter:  rransom  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by rl1987):

 {{{
 # XXXX Is this used?
 git mv contrib/cross.sh contrib/build-tools/cross.sh
 }}}
 This is a cross-compilation helper script that was maintained from 2006 to
 2009. It's probably no longer in any use, since there was some effort to
 have standard autotools-based build system support cross-compilation (see
 ticket #9869).

 {{{
 # XXXX Do we use this?
 git mv contrib/netinst.nsi contrib/build-tools/netinst.nsi
 # XXXX Do we use this?
 git mv contrib/package_nsis-mingw.sh contrib/build-tools/package_nsis-
 mingw.sh
 # XXXX Do we use this?
 git mv contrib/tor.ico contrib/build-tools/tor.ico
 # XXXX Do we use this?
 git mv contrib/torinst32.ico contrib/build-tools/torinst32.ico
 # XXXX Do we use this?
 git mv contrib/xenobite.ico contrib/build-tools/xenobite.ico
 }}}
 All of these seem to be related to TBB and Tor expert bundle. Arguably,
 core Tor codebase is not where they should be, even if they are used
 (pretty sure they're not, judging from the fact that NSIS stuff was last
 updated in 2011 and icon files were added in 2006).

 {{{
 # contrib/dir-tools/directory-archive/
 # Tools for running a directory archive.  Are they used?
 git mv contrib/directory-archive/crontab.sample contrib/dir-tools
 /directory-archive/crontab.sample
 git mv contrib/directory-archive/fetch-all contrib/dir-tools/directory-
 archive/fetch-all
 git mv contrib/directory-archive/fetch-all-v3 contrib/dir-tools/directory-
 archive/fetch-all-v3
 git mv contrib/directory-archive/tar-them-up contrib/dir-tools/directory-
 archive/tar-them-up
 git mv contrib/directory-archive/fetch-all-functions contrib/dir-tools
 /directory-archive/fetch-all-functions
 git mv contrib/directory-archive/sort-into-month-folder contrib/dir-tools
 /directory-archive/sort-into-month-folder
 }}}

 I don't know. They ''might'' be useful to researcher who wants an easy way
 to download data from Tor directory servers to do some kind of math, but
 Onionoo web services kinda make these scripts obsolete. Besides, these
 scripts haven't been updated in a while and may be buggy and/or fail to
 implement the latest developments in Tor directory protocol.

 {{{
 # XXXX is this used? Does it work?
 git mv contrib/mdd.py scripts/mdd.py
 }}}
 This is a Python script to generate call graph for C code. It was added in
 2004 and has not been updated since then. It does work if you change the
 first line to `#!/usr/bin/env python`, but it is fairly certain nobody
 uses it anymore. Doxygen being able to generate call-graphs with pretty
 pictures makes it basically obsolete.

 {{{
 # XXXX is this used? Does it work?
 git mv contrib/redox.py scripts/redox.py
 }}}

 This was supposed to solve some sort of problem with Doxygen. I gave it a
 try and it failed with Python error:

 {{{
 Traceback (most recent call last):
   File "./contrib/redox.py", line 213, in <module>
     comments = checkf(fn, errs)
   File "./contrib/redox.py", line 154, in checkf
     if any(pat.match(name) for pat in SKIP_NAMES):
   File "./contrib/redox.py", line 154, in <genexpr>
     if any(pat.match(name) for pat in SKIP_NAMES):
 TypeError: expected string or buffer
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8966#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online