[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

[Tor Bug Tracker & Wiki]

#7472: Audit all calls to connection_mark_for_close()
------------------------+--------------------------------
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.5-alpha
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 * conn_read_callback():
    - Correction: channel_tls_handle_incoming() gets called in
 connection_tls_start_handshake() before tor_tls_new().  I still believe
 this path is safe because connection_or_process_inbuf() will
 connection_or_close_for_error() if connection_tls_start_handshake() fails.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online