[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

[Tor Bug Tracker & Wiki]

#7472: Audit all calls to connection_mark_for_close()
------------------------+--------------------------------
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.5-alpha
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 * conn_read_callback():
  - I think there may be a few paths along which connection_handle_read()
 can fail to mark the connection.  In particular, connection_handle_read()
 -> connection_handle_read_impl() -> connection_process_inbuf() ->
 connection_or_process_inbuf() -> connection_tls_start_handshake(), and
 then tor_tls_new() fails in connection_tls_start_handshake().  This may be
 a can't-happen for other reasons and I don't think it can lead to any bad
 interactions with channels because the new or_connection is not yet
 associated with a channel at that point.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online