[tor-bugs] #11279 [Tor]: Quiet some warns for protocol errors setting rendezvous points

[Tor Bug Tracker & Wiki]

#11279: Quiet some warns for protocol errors setting rendezvous points
-----------------------------+------------------------------------
 Reporter:  arma             |          Owner:
     Type:  defect           |         Status:  new
 Priority:  normal           |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:
 Keywords:  easy, tor-relay  |  Actual Points:
Parent ID:                   |         Points:
-----------------------------+------------------------------------
 In https://lists.torproject.org/pipermail/tor-
 relays/2014-March/004031.html we see a relay operator reporting lots of
 "Invalid length on ESTABLISH_RENDEZVOUS" errors.

 The code in question is in rend_mid_establish_rendezvous():
 {{{
   if (request_len != REND_COOKIE_LEN) {
     log_warn(LD_PROTOCOL, "Invalid length on ESTABLISH_RENDEZVOUS.");
 }}}

 Seems to me that log_warn should be a log_protocol_warn, since there's
 nothing the relay operator should do about some client not obeying the
 protocol.

 Are there other log_warns in this vicinity that we should change also? I
 looked around a bit and didn't see others.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11279>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online