[tor-bugs] #11269 [Obfsproxy]: Misplaced comma in scramblesuit.py

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Mar 22 06:41:06 UTC 2014


#11269: Misplaced comma in scramblesuit.py
--------------------------+---------------------
 Reporter:  yawning       |          Owner:  asn
     Type:  defect        |         Status:  new
 Priority:  trivial       |      Milestone:
Component:  Obfsproxy     |        Version:
 Keywords:  scramblesuit  |  Actual Points:
Parent ID:                |         Points:
--------------------------+---------------------
 A misplaced comma in a raise statement causes a ValuError instead of a
 helpful message to the user.

 Reported on #tor by picuntu-ul.

 Since it's totally trivial, I'll inline the fix as well:
 {{{
 diff --git a/obfsproxy/transports/scramblesuit/scramblesuit.py
 b/obfsproxy/transports/scramblesuit/scramblesuit.py
 index 9262b34..bff0069 100644
 --- a/obfsproxy/transports/scramblesuit/scramblesuit.py
 +++ b/obfsproxy/transports/scramblesuit/scramblesuit.py
 @@ -551,7 +551,7 @@ class ScrambleSuitTransport( base.BaseTransport ):
              rawLength = len(uniformDHSecret)
              if rawLength != const.SHARED_SECRET_LENGTH:
                  raise base.PluggableTransportError(
 -                    "The UniformDH password must be %d bytes in length,
 ",
 +                    "The UniformDH password must be %d bytes in length, "
                      "but %d bytes are given."
                      % (const.SHARED_SECRET_LENGTH, rawLength))
              else:
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11269>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list