[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by andrea):

 Replying to [comment:20 nickm]:
 > Still have the core? any chance of seeing what was in *circ?

 (gdb) frame 3
 #3  0x00000000004a6bf3 in circuit_mark_for_close_ (circ=0x2427ef0,
 reason=1, line=352,
     file=0x5bfbe0 "src/or/command.c") at src/or/circuitlist.c:1397
 1397    src/or/circuitlist.c: No such file or directory.
         in src/or/circuitlist.c
 (gdb) print *circ
 $1 = {magic = 4148688768, n_chan = 0x0, n_circ_id = 0, n_mux = 0x2427f30,
 n_chan_cells = {head = 0x0,
     tail = 0x7ffff71a9840, n = -143680640, insertion_times = 0x71}, n_hop
 = 0xe6222efb7a94a304,
   streams_blocked_on_n_chan = 1, streams_blocked_on_p_chan = 1, state =
 225 '\341', purpose = 64 '@',
   package_window = -1135566341, deliver_window = 1469111653,
 n_chan_create_cell = 0xa2a583aa00000000,
   timestamp_began = {tv_sec = 6385653667941287783, tv_usec = 0},
 timestamp_created = {tv_sec = 0, tv_usec = 0},
   timestamp_dirty = 0, marked_for_close = 0, marked_for_close_file = 0x0,
 dirreq_id = 51539607552,
   next = 0x7ffff76f9708, next_active_on_n_chan = 0x41,
 prev_active_on_n_chan = 0x0}

 I have a copy of the core dump if you want to look closer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online