[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by andrea):

 This branch just died with 'src/or/circuitlist.c:1726 assert_circuit_ok:
 Assertion c->magic == ORIGIN_CIRCUIT_MAGIC || c->magic == OR_CIRCUIT_MAGIC
 failed; aborting.'  Stack trace follows:

 #0  0x00007ffff69359b5 in raise () from /lib64/libc.so.6
 #1  0x00007ffff693705f in abort () from /lib64/libc.so.6
 #2  0x00000000004a82d4 in assert_circuit_ok (c=0x2427ef0) at
 src/or/circuitlist.c:1726
 #3  0x00000000004a6bf3 in circuit_mark_for_close_ (circ=0x2427ef0,
 reason=1, line=352,
     file=0x5bfbe0 "src/or/command.c") at src/or/circuitlist.c:1397
 #4  0x00000000004bdf76 in command_process_created_cell
 (cell=0x7fffffffdd40, chan=0x21cc0e0) at src/or/command.c:352
 #5  0x00000000004bd3c7 in command_process_cell (chan=0x21cc0e0,
 cell=0x7fffffffdd40) at src/or/command.c:143
 #6  0x000000000048c6c6 in channel_queue_cell (chan=0x21cc0e0,
 cell=0x7fffffffdd40) at src/or/channel.c:2540
 #7  0x00000000004941b8 in channel_tls_handle_cell (cell=0x7fffffffdd40,
 conn=0x224e780) at src/or/channeltls.c:923
 #8  0x00000000004ed0bf in connection_or_process_cells_from_inbuf
 (conn=0x224e780) at src/or/connection_or.c:1972
 #9  0x00000000004e9664 in connection_or_process_inbuf (conn=0x224e780) at
 src/or/connection_or.c:483
 #10 0x00000000004dc28e in connection_process_inbuf (conn=0x224e780,
 package_partial=1) at src/or/connection.c:4001
 #11 0x00000000004d9a2a in connection_handle_read_impl (conn=0x224e780) at
 src/or/connection.c:2839
 #12 0x00000000004d9b57 in connection_handle_read (conn=0x224e780) at
 src/or/connection.c:2880
 #13 0x000000000040bafb in conn_read_callback (fd=33, event=2,
 _conn=0x224e780) at src/or/main.c:718
 #14 0x00007ffff770cdd4 in event_process_active_single_queue
 (base=0x826e10, flags=<value optimized out>)
     at event.c:1350
 #15 event_process_active (base=0x826e10, flags=<value optimized out>) at
 event.c:1420
 #16 event_base_loop (base=0x826e10, flags=<value optimized out>) at
 event.c:1621
 #17 0x000000000040e65d in do_main_loop () at src/or/main.c:1987
 #18 0x000000000040fda3 in tor_main (argc=3, argv=0x7fffffffe5f8) at
 src/or/main.c:2703
 #19 0x0000000000409d74 in main (argc=3, argv=0x7fffffffe5f8) at
 src/or/tor_main.c:30

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online