[tor-bugs] #8948 [Tor]: Write a "code review guidelines" page

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 10 23:20:17 UTC 2014

#8948: Write a "code review guidelines" page
     Reporter:  nickm        |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-doc
Actual Points:               |  Parent ID:
       Points:               |

Comment (by andrea):

 Triage for 0.2.5.x: do we have any idea which of the several things
 described here we want to do?  The original ticket sounds like it really
 wants a wiki page or something, so doesn't quite seem to make sense
 targeting a specific release of Tor.  OTOH, if we want a make target, we
 should probably have a clearer idea what we want it to do beyond what make
 check-spaces already does.

 The most substantive requirement for new patches we've introduced since
 this is the no-new-uncovered-lines rule; it'd be nice to have an automated
 way to check that - diff output filtered for only chunks that add a new
 uncovered line, perhaps? - but we need to make the automated cov-diff tool
 smarter before we can do that (see #11145, #11146).

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8948#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list