[tor-bugs] #10761 [Firefox Patch Issues]: Restoring windows and tabs causes crash on exit

[Tor Bug Tracker & Wiki]

#10761: Restoring windows and tabs causes crash on exit
--------------------------------------+-----------------------
     Reporter:  cypherpunks           |      Owner:  mikeperry
         Type:  defect                |     Status:  new
     Priority:  normal                |  Milestone:
    Component:  Firefox Patch Issues  |    Version:
   Resolution:                        |   Keywords:  tbb-crash
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+-----------------------

Comment (by cypherpunks):

 More simple scenario.
 Any call of error_get_my_stack() in between calls of
 nss_DestroyErrorStack() fills private data and trigger destructor from
 unloaded dll. Or call of the same  error_get_my_stack() after last
 nss_DestroyErrorStack() and before _PR_DestroyThreadPrivate called on
 thread termination.
 Like this part:
 {{{
 1101     nss_DestroyErrorStack();
 1102     nssArena_Shutdown();
 1103     if (status == PR_FAILURE) {
 1104    if (NSS_GetError() == NSS_ERROR_BUSY) {
 }}}
 Calling of NSS_GetError() restores error stack again.
 Failure of [https://mxr.mozilla.org/mozilla-
 central/source/security/nss/lib/pki/pki3hack.c#203 STAN_Shutdown()] leads
 to crash on thread termination for mingw compiled firefox.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10761#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online