[tor-bugs] #9264 [BridgeDB]: Problem with transport lines in BridgeDB's bridge pool assignment files

[Tor Bug Tracker & Wiki]

#9264: Problem with transport lines in BridgeDB's bridge pool assignment files
--------------------------+----------------------------
     Reporter:  karsten   |      Owner:  isis
         Type:  defect    |     Status:  reopened
     Priority:  major     |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  bridgedb-0.1.3
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+----------------------------

Comment (by sysrqb):

 I pushed bug9264_rebased_2 to my repo. The short description of the bug is
 that when we reparsed the descriptors we never checked if we already had
 the bridge, so we appended it to a list every time. With this patch we'll
 check if we already have a bridge with the same fingerprint and overwrite
 it if we do, otherwise we append as before.

 Another option is to change the list to a dict, but O(n) complexity of
 scanning a list linearly should be fairly quick in this case.

 I added a unit test for this which successfully tests this duplicate-
 bridge-insertion case, however travis-ci is choking some other parts of
 the tests.
 https://travis-ci.org/sysrqbci/bridgedb/builds/20051728

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9264#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online