[tor-bugs] #8387 [Tor]: Unbuilt one-hop circuits sometimes hang around forever

[Tor Bug Tracker & Wiki]

#8387: Unbuilt one-hop circuits sometimes hang around forever
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  nickm
  mikeperry              |     Status:  needs_information
         Type:  defect   |  Milestone:  Tor: 0.2.5.x-final
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  tor-client MikePerry201406R
   Resolution:           |  025-triaged
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Well, that's strange!  I had kind of thought that there would still be
 streams on these.  But it isn't logging anything about streams.

 Oh, here is a possible dumb bug: What if it isn't calling
 circuit_expire_old_circuits_clientside() at all?  The
 circuit_expire_old_circuits_clientside() function is supposed to be
 getting called from circuit_build_needed_circs()... and
 circuit_build_needed_circs is called only when have_dir_info &&
 !net_is_disabled().

 I wonder which one of those might be false?  Does have_dir_info become
 false after running as a relay for a while, or do we think we're
 hibernating for some reason?

 The sensible fix is probably to call
 circuit_expire_old_circuits_clientside even when we aren't calling
 circuit_build_needed_circuits().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8387#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online