[tor-bugs] #12406 [Tor bundles/installation]: use MinGW-w64 v3.1.0 for TBB 4.x

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 20 14:20:24 UTC 2014


#12406: use MinGW-w64 v3.1.0 for TBB 4.x
------------------------------------------+------------------------------
     Reporter:  mcs                       |      Owner:  erinn
         Type:  defect                    |     Status:  closed
     Priority:  normal                    |  Milestone:
    Component:  Tor bundles/installation  |    Version:
   Resolution:  fixed                     |   Keywords:  MikePerry201406R
Actual Points:                            |  Parent ID:
       Points:                            |
------------------------------------------+------------------------------
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 mcs]:
 > The SVN developers did not create a signed tag for v3.0.1 so I just used
 the corresponding commit hash.
 >
 > The new branch is bug12406-02 within /user/brade/tor-browser-bundle.git,
 i.e.,
 > https://gitweb.torproject.org/user/brade/tor-browser-
 bundle.git/shortlog/refs/heads/bug12406-02
 >
 > As before, the most recent two commits are the ones to look at.
 >
 > Switching to git for MinGW-w64 was a little tricky because we build into
 a directory named mingw-w64 which conflicts with the "natural" directory
 that git would clone into.  The solution we adopted is to clone into
 mingw-w64-git and keep everything else the same.  To do that we had to
 tweak update_git() within fetch-inputs.sh to clone into the configured
 dir.

 Yes, having this explicit when cloning is even better. (Especially if one
 uses that directory later to check for something as we do).

 > Please review.  One question:  is it sufficient to just check_git_hash()
 for MinGW-w64? (see our changes inside verify-tags.sh)

 Yes.

 Thanks. Merged in commit 7dae61fbd8e3074f5611ed3d892a669f8429f5b7 and
 24677e9dad9092ba9fdaff751aef37b9ad3953e1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12406#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list