[tor-bugs] #12184 [Tor]: Circuit on detached list which I had no reason to mark

[Tor Bug Tracker & Wiki]

#12184: Circuit on detached list which I had no reason to mark
-----------------------------+--------------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  needs_review
     Priority:  major        |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:  Tor: 0.2.5.4-alpha
   Resolution:               |   Keywords:  024-backport 025-triaged
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------------

Comment (by yawning):

 Was asked to look over the diff on IRC, and the only thing that stood out
 was

 [https://gitweb.torproject.org/nickm/tor.git/blob/b2fa94239c4ab182ec7bc3bccbee70ee80149783:/src/or/circuitbuild.c#l179
 circuitbuild.c:179]
 {{{
       if (0)
         circuitmux_assert_okay(chan->cmux);
 }}}

 Per nickm:
 > that's there so I can tell people "remove that line if you know how to
 use gdb and you want to help us debug it and you don't mind a little extra
 crashing"

 Suggest a comment there stating intent.

 [https://gitweb.torproject.org/nickm/tor.git/blob/b2fa94239c4ab182ec7bc3bccbee70ee80149783:/src/or/circuitmux.c#l1912
 circuitmux.c:1912]
 {{{
 /*DOCODC; for debugging 12184.  This runs slowly. */
 }}}

 Typeo.

 The actual code looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12184#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online