[tor-bugs] #12219 [Tor]: Clean dead code from entrynodes.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 6 15:25:54 UTC 2014


#12219: Clean dead code from entrynodes.c
-----------------------+------------------------------------
 Reporter:  asn        |          Owner:
     Type:  defect     |         Status:  new
 Priority:  trivial    |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor        |        Version:
 Keywords:  tor-guard  |  Actual Points:
Parent ID:             |         Points:
-----------------------+------------------------------------
 I see dead code in `entrynodes.c`.

 There are three blocks of `#if 0` code. One of them is particularly
 annoying because it's in the middle of `choose_random_entry_impl()` which
 is an important function, and it makes it harder to read.

 I would say that all dead code needs to go to the graveyard (git history
 in our case).

 (We '''might''' want to keep the dead code in
 `control_event_guard_deferred()`, which is currently a NOP, just to show
 what that function used to be.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12219>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list