[tor-bugs] #12205 [Tor]: Document magic numbers at entry_is_time_to_retry()

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jun 4 18:36:39 UTC 2014


#12205: Document magic numbers at entry_is_time_to_retry()
-----------------------+---------------------
 Reporter:  asn        |          Owner:
     Type:  defect     |         Status:  new
 Priority:  minor      |      Milestone:
Component:  Tor        |        Version:
 Keywords:  tor-guard  |  Actual Points:
Parent ID:             |         Points:
-----------------------+---------------------
 {{{
  if (diff < 6*60*60)
     return now > (e->last_attempted + 60*60);
   else if (diff < 3*24*60*60)
     return now > (e->last_attempted + 4*60*60);
   else if (diff < 7*24*60*60)
     return now > (e->last_attempted + 18*60*60);
   else
     return now > (e->last_attempted + 36*60*60);
 }
 }}}

 This is our entry guard retry logic. We should probably document these
 numbers, so that they look less magic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12205>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list