[tor-bugs] #12688 [Tor]: Make NumEntryGuards configurable by the consensus

[Tor Bug Tracker & Wiki]

#12688: Make NumEntryGuards configurable by the consensus
-----------------------------+--------------------------------
     Reporter:  arma         |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client
Actual Points:               |  Parent ID:  #11480
       Points:               |
-----------------------------+--------------------------------

Comment (by andrea):

 Begin code review of arma's ticket12688 branch:

 1e3af73898cc51a75298de08204fccaedf97da25:
  - I think nickm is right about not picking guards before having a
 consensus, but I thought we were trying to get away from 3 guards?  I'd
 feel slightly better if the default value passed into
 networkstatus_get_param() weren't the case we were trying to avoid, but I
 believe this is okay.

 7ecc86463ca42ee37f0140006ef077847439e97b:
  - I think this is okay.

 5c7356468bc6e08fafbc3a84b06e90b471d63c3d:
  - This is fine.

 End code review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12688#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online