[tor-bugs] #12691 [Tor]: does not build with clang

[Tor Bug Tracker & Wiki]

#12691: does not build with clang
--------------------+------------------------------------
 Reporter:  weasel  |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:  Tor: unspecified
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 On master, tor's test suite does not build with clang on i386.  The
 0.2.5.x tree is fine.

 From https://jenkins.torproject.org/job/tor-ci-linux-master-
 clang/ARCHITECTURE=i386,SUITE=sid/6/console:
 {{{
 19:56:16 src/test/test_util.c:2407:13: error: implicit conversion loses
 integer precision: 'off_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(tor_fd_getpos(fd), ==, strlen(message));
 19:56:16   ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 src/test/test_util.c:2409:16: error: implicit conversion loses
 integer precision: '__off64_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(st.st_size, ==, strlen(message));
 19:56:16   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 src/test/test_util.c:2413:13: error: implicit conversion loses
 integer precision: 'off_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(tor_fd_getpos(fd), ==, 0);
 19:56:16   ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 src/test/test_util.c:2415:16: error: implicit conversion loses
 integer precision: '__off64_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(st.st_size, ==, 0);
 19:56:16   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 src/test/test_util.c:2420:13: error: implicit conversion loses
 integer precision: 'off_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(tor_fd_getpos(fd), ==, strlen(message2));
 19:56:16   ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 src/test/test_util.c:2422:16: error: implicit conversion loses
 integer precision: '__off64_t' (aka 'long long') to 'long'
 [-Werror,-Wshorten-64-to-32]
 19:56:16   tt_int_op(st.st_size, ==, strlen(message2));
 19:56:16   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 19:56:16 ./src/ext/tinytest_macros.h:158:22: note: expanded from macro
 'tt_int_op'
 19:56:16         tt_assert_test_type(a,b,#a" "#op" "#b,long,(val1_ op
 val2_), \
 19:56:16                             ^
 19:56:16 ./src/ext/tinytest_macros.h:144:26: note: expanded from macro
 'tt_assert_test_type'
 19:56:16         tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt,
 \
 19:56:16                                 ^
 19:56:16 ./src/ext/tinytest_macros.h:116:16: note: expanded from macro
 'tt_assert_test_fmt_type'
 19:56:16         type val1_ = (a);
 \
 19:56:16                       ^
 19:56:16 6 errors generated.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12691>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online