[tor-bugs] #12684 [Firefox Patch Issues]: Make "Not Now" the default button for TorBrowser's canvas permission dialogue

Wed Jul 23 10:29:38 UTC 2014

#12684: Make "Not Now" the default button for TorBrowser's canvas permission
dialogue
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_revision
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-usability, tbb-
   Resolution:                       |  linkability
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-------------------------------------

Comment (by gk):

 Replying to [comment:7 isis]:
 > FWIW, I tried to patch TorBrowser, in `tor-
 browser.git/browser/base/content/browser.js`, around L6030:

 <snip>

 > I re-zipped that into `tor-browser_en-US/Browser/browser/omni.ja` in my
 browser tree, and restarted the browser several times, but debug logs gave
 me no idea why it wasn't running. And [https://developer.mozilla.org/en-
 US/docs/Mozilla/JavaScript_code_modules/PopupNotifications.jsm#Notification_options
 MDN didn't help]. Bad JS syntax? Any idea what I did wrong?

 Not yet. But given the patch you tried it is probably not the one you
 really want: https://mxr.mozilla.org/mozilla-
 esr24/source/toolkit/modules/PopupNotifications.jsm#198

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12684#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online