[tor-bugs] #12663 [Orbot]: Orbot, libevent and BSD sed ( includes patch )

[Tor Bug Tracker & Wiki]

#12663: Orbot, libevent and BSD sed ( includes patch )
-------------------------+----------------------------------------
 Reporter:  cypherpunks  |          Owner:  n8fr8
     Type:  defect       |         Status:  new
 Priority:  minor        |      Milestone:
Component:  Orbot        |        Version:  Android (Orbot): 1.0.0
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
-------------------------+----------------------------------------
 Compilation of Orbot stops at libevent if using BSD sed rather than GNU
 sed.

 The error is :

 sed -i 's@\(SUBDIRS = . include\) sample test@\1@' libevent/Makefile.am
 sed: 1: "libevent/Makefile.am": extra characters at the end of l command

 I have traced the problem to Orbot's external/Makefile.

 There is a difference between BSD and GNU sed with regards to the inplace
 -i flag, both accept an argument for a file extension to backup to, if no
 extension is provided no backup is made, however BSD sed requires an
 argument even if it is empty, whereas GNU sed ignores it.

 The attached patch adds an extension rather than provide an empty
 argument, this *should* work with both GNU and BSD sed, though I haven't
 tried it with the former.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12663>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online