[tor-bugs] #11045 [Stem]: Check consensus signatures

[Tor Bug Tracker & Wiki]

#11045: Check consensus signatures
-----------------------------+--------------------------
     Reporter:  atagar       |      Owner:  nickm
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Stem         |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by atagar):

 Hi Nick, I took a quick peek to see if I could apply this before heading
 on my trip but ran into issues. Did you run the unit tests? I'm getting
 seventeen failures plus static checker issues...

 {{{
 % patch -p1 < ~/Desktop/0001-Refactoring-for-checking-consensus-
 signatures.patch
 patching file stem/descriptor/__init__.py
 patching file stem/descriptor/networkstatus.py
 patching file stem/descriptor/server_descriptor.py

 % ./run_tests.py --unit
 ...
 STATIC CHECKS
 * /home/atagar/Desktop/stem/stem/descriptor/__init__.py
   line 383  - line has trailing whitespace
   line 394  - W293 W293 blank line contains whitespace
   line 396  - E303 E303 too many blank lines (4)
   line 420  - W291 W291 trailing whitespace
   line 619  - E302 E302 expected 2 blank lines, found 1

 * /home/atagar/Desktop/stem/stem/descriptor/networkstatus.py
   line 607  - line has trailing whitespace
   line 624  - W293 W293 blank line contains whitespace
   line 626  - E303 E303 too many blank lines (5)
   line 640  - E261 E261 at least two spaces before inline comment
   line 653  - W291 W291 trailing whitespace
   line 1467 - line has trailing whitespace
   line 1471 - line has trailing whitespace
   line 1485 - line has trailing whitespace
   line 1488 - W293 W293 blank line contains whitespace
   line 1492 - E303 E303 too many blank lines (4)
   line 1513 - W291 W291 trailing whitespace
   line 1547 - W291 W291 trailing whitespace
   line 1581 - W291 W291 trailing whitespace

 * /home/atagar/Desktop/stem/stem/descriptor/server_descriptor.py
   line 36   - 'codecs' imported but unused
   line 729  - W293 W293 blank line contains whitespace
   line 764  - W293 W293 blank line contains whitespace
   line 779  - E231 E231 missing whitespace after ','
   line 787  - E231 E231 missing whitespace after ','
   line 794  - E231 E231 missing whitespace after ','

 TESTING FAILED (9 seconds)
   [UNIT TEST] test_archived_bz2
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_archived_gzip
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_archived_uncompressed
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_basic_example
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_multiple_runs
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_persistence_path
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_skip_nondescriptor_contents
 (test.unit.descriptor.reader.TestDescriptorReader) ... FAIL
   [UNIT TEST] test_can_iterate_multiple_times
 (test.unit.descriptor.remote.TestDescriptorDownloader) ... FAIL
   [UNIT TEST] test_query_download
 (test.unit.descriptor.remote.TestDescriptorDownloader) ... FAIL
   [UNIT TEST] test_cr_in_contact_line
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_metrics_descriptor
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_metrics_descriptor_multiple
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_negative_uptime
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_non_ascii_descriptor
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_old_descriptor
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_with_tarfile_object
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
   [UNIT TEST] test_with_tarfile_path
 (test.unit.descriptor.server_descriptor.TestServerDescriptor) ... ERROR
 }}}

 Please make sure the unit tests, integ tests, and pyflakes/pep8 all
 pass...

 https://stem.torproject.org/faq.html#how-do-i-run-the-tests

 No rush. As mentioned previously I won't be able to get to this again
 until after the 28th. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11045#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online