[tor-bugs] #10887 [Obfsproxy]: ScrambleSuit should make it easy for bridge admins to learn password
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jul 16 14:57:24 UTC 2014
#10887: ScrambleSuit should make it easy for bridge admins to learn password
-------------------------+-------------------------------------------------
Reporter: phw | Owner: phw
Type: | Status: needs_revision
enhancement | Milestone:
Priority: normal | Version:
Component: | Keywords: scramblesuit, password, shared
Obfsproxy | secret
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Changes (by yawning):
* status: needs_review => needs_revision
Comment:
Round 2:
* ed4f43f21a2be32ecdb0fd0ba6dbccfe8188309e - "Ensure files get removed in
unittests (using the tearDown() method)."
* ACK.
* f20141be653872d5ef3243618e0e4274c8ba8131 - "fixup! Write password to a
file, instead of the whole Bridge line."
* "Bridge [<transport>] <address>:<port> [<id-fingerprint>] [<k>=<v>]
[<k>=<v>] [<k>=<v>]". Password and fingerprint on the example bridgeline
are flipped. I would use "EXAMPLEFINGERPRINTNOTREAL" there instead of an
opaque hex identifier.
* 4e46bce1ac0e368368dd0171aad205b0267c0706 - "Add a ChangeLog entry about
the new run_transport_setup() behavior."
* ACK.
After you flip the fingerprint and password so the example actually
conforms to the pt-spec, I think this is ok to merge. Thanks for all the
work!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10887#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list