[tor-bugs] #4019 [Tor]: Tor warns about public SocksPort addresses twice on startup

[Tor Bug Tracker & Wiki]

#4019: Tor warns about public SocksPort addresses twice on startup
-------------------------+--------------------------------
     Reporter:  rransom  |      Owner:  tomfitzhenry
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-client easy
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by nickm):

 This approach seems , but I don't think validate_only is really the right
 flag to use for this: Warning is a form of validation, after all.  The
 convention for the validate_only flag elsewhere is that it applies to
 functions where validation happens in all cases, but applying the changes
 is optional.

 I wonder, should this instead use a local static flag to track whether the
 warning has been given?  Or maybe a flag on the port object or
 something...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4019#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online