[tor-bugs] #11400 [Flashproxy]: Status lists itself as "dead" inaccurately

[Tor Bug Tracker & Wiki]

#11400: Status lists itself as "dead" inaccurately
----------------------------+--------------------------
     Reporter:  saint       |      Owner:  dcf
         Type:  defect      |     Status:  needs_review
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+--------------------------

Comment (by saint):

 Replying to [comment:2 dcf]:
 > Here's a summary of my thinking:
 >  1. The code transitions to "dead" in all the places it was meant to.
 >  2. However, "dead" doesn't work the way it was meant to: it was
 supposed to turn off all future network activity, just like "disabled"
 does.
 >  3. However however, it appears that this behavior is not what Cupcake
 wants--it wants to continue polling after a network error.
 >
 > How do these patches work for you? An alternative to the second patch is
 to increment a counter or something, and then actually die (up until the
 next daily refresh) after a threshold is passed.

 I agree with your line of thinking - dying works well on a standard page
 because refreshing the page automatically restarts flashproxy.js.  In
 Cupcake's Chrome extension, things get trickier because it's running in
 the background until browser restart (Linux) or *system* restart
 (Win/OSX).  Patch #2 has tested as fine, so is being merged.  This 'bug'
 usually appears when someone is behind a captive portal, so it letting it
 attempt to poll the facilitator again seems like it would be fine.  And as
 you point out, this is Cupcake's default behavior currently, just with an
 error status.

 I may add a counter in addition to Patch #2 just to keep the original
 failsafe behavior intact.  Thank you for the patch =)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11400#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online