[tor-bugs] #10449 [Tor]: Tor launcher shuts down poorly when its Tor is a relay

[Tor Bug Tracker & Wiki]

#10449: Tor launcher shuts down poorly when its Tor is a relay
------------------------+-----------------------
     Reporter:  arma    |      Owner:  brade
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------------

Comment (by arma):

 Replying to [comment:4 nickm]:
 > (Note that this is relevant only for crashing controllers: controllers
 that are doing a controlled shutdown can themselves decide how to turn off
 Tor.)

 Interesting point -- I assume we're having this conversation because tor
 launcher decided to leave it to tor how to shut down. Does that mean you
 recommend that Tor Launcher send Tor some other signal before closing the
 connection? This seems to be one of those cases where if we're going to
 recommend that every controller do some behavior, it's better to have it
 happen on the Tor side.

 Do we know of any cases where, once you've set takeownership, for a Tor
 that's a relay, you'll want to let the Tor persist a while more even
 though the controller has vanished?

 I would think that if the controller wants to do something fancy like a
 controlled shutdown of Tor, it shouldn't close its control port until it's
 done doing the fancy thing.

 So to be clear, I think we'll be happier here just changing
 lost_owning_controller() so it calls tor_cleanup and exits.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10449#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online