[tor-bugs] #11069 [Tor]: Tor with unreachable PTs should not hang the bootstrap process

[Tor Bug Tracker & Wiki]

#11069: Tor with unreachable PTs should not hang the bootstrap process
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by asn):

 * status:  new => needs_review


Comment:

 OK. See branch `bug11069` in
 `https://git.torproject.org/user/asn/tor.git`.

 After some testing it seems to work fine.

 A thing I'm not so sure about is that I moved
 `connection_or_notify_error()` after the connection has been marked for
 closing. There doesn't seem to be anything wrong with that, but that
 function also calls `channel_close_for_error()` and I'm not sure if the
 channel subsystem cares about whether the connection has been closed or
 not.

 Also, are there any other attributes of the connection that we should be
 checking in `any_active_or_conns()`? We could check whether its state is
 `OR_CONN_STATE_CONNECTING` for example, but I'm not sure if this is a good
 idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11069#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online