[tor-bugs] #10928 [Tor]: Stat information is not obtained properly in test test_config_check_or_create_data_subdir

[Tor Bug Tracker & Wiki]

#10928: Stat information is not obtained properly in test
test_config_check_or_create_data_subdir
--------------------+------------------------------------
 Reporter:  _x3j11  |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 The test test_config_check_or_create_data_subdir makes a stat call that is
 asserted to fail, but then a successful stat call is not made at all. This
 means that the stat information st is not initialized, and can potentially
 contain garbage which would mean the permission information used by chmod
 would be invalid and the chmod call would fail.

 The attached patch simply executes stat again (as well as changes
 test_fail_msg to tt_abort_perror, so information why a step has failed can
 be better communicated).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10928>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online