[tor-bugs] #10872 [Pluggable transport]: review of obfsclient

[Tor Bug Tracker & Wiki]

#10872: review of obfsclient
-------------------------------------+-----------------------
     Reporter:  infinity0            |      Owner:  infinity0
         Type:  task                 |     Status:  assigned
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-----------------------

Comment (by yawning):

 Re: The Aes128Ctr situation.

 My (unpushed) scramblesuit branch has a ever so slightly better documented
 version of the code, and the classes are named
 Aes128Ctr/Aes192Ctr/Aes256Ctr (Technically they're a bunch of typedefs
 since "AesCtr<AesEcb<::EVP_aes_128_ecb, kAes128KeyLength>>" is horrendous
 to type.

 In theory this will let me more easily change out the CTR mode
 implementation to something that isn't ECB based later as long as I use
 the typedefs (I don't use OpenSSL's because I don't particularly care for
 eviscerating the required number of goats and reading their entrails to
 figure out what versions actually provide working EVP_aes_FOO_ctr.).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10872#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online