[tor-bugs] #4817 [Tor]: Control port authentication failures don't differentiate failure types

[Tor Bug Tracker & Wiki]

#4817: Control port authentication failures don't differentiate failure types
-------------------------+-------------------------------------------
     Reporter:  atagar   |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  trivial  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  easy maybe-proposal tor-relay
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------

Comment (by nickm):

 I tweaked this in my branch "feature4817" in my public repository so that
 it would work.

 I'm not sure of whether to merge this, though.  Basically, this patch is
 equivalent to having the controller do, "if you sent no authentication and
 you get a 515, assume that you were supposed to send authentication."
 Controller writers, is it IYO worth fixing?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4817#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online