[tor-bugs] #10598 [Obfsproxy]: Merge ScrambleSuit v2014.01.a.

[Tor Bug Tracker & Wiki]

#10598: Merge ScrambleSuit v2014.01.a.
-----------------------------+-----------------------------------------
     Reporter:  phw          |      Owner:  asn
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Obfsproxy    |    Version:
   Resolution:               |   Keywords:  pt, obfsproxy, scramblesuit
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------------

Comment (by asn):

 Replying to [comment:21 phw]:
 > Replying to [comment:18 asn]:
 > > BTW Philipp, you might be able to use the
 `get_public_server_options()` transport method that David Stainton
 recently added to obfsproxy, so that you generate a password if the admin
 hadn't specified one.
 > >
 > > Then you can save it to a file in `TOR_PT_STATE_LOCATION` and use it
 the next time you boot up.
 > >
 > > Does this make sense? You think it might be too messy?
 >
 > I just added this to master:
 https://gitweb.torproject.org/user/phw/scramblesuit.git/commitdiff/7c3c519889ffb721bc1f71fdd3d1550ffe0dfb39
 >
 > I think it's a good idea and the benefit clearly outweighs the (small)
 messiness: We no longer need to force bridge operators to set
 `ServerTransportOptions`.  I'll do some more testing and then create
 another obfsproxy branch.

 Hm. I just skimmed over the patch. I will look more into it soon.

 I wonder if we can move all this file-creation/reading logic to
 `__init__()` instead of `get_public_server_options()`. It would be more
 suiting I think.

 Also where is `SERVER_PASSWORD_FILE` initialized in the pushed code?

 We should also think what we want to happen if a person sets up a
 `ServerTransportOptions` line after a `SERVER_PASSWORD_FILE` has been
 created.

 Maybe we could have a more descriptive log message than `No password found
 in transport options.`. Maybe it should be directed to the bridge operator
 and say `No password was specified. Generating and caching a new one.`.
 Maybe there should also be a log message for `Found a cached password.
 Using this one`.

 We should also figure out what happens if `writeToFile` fails. This might
 be better handled by moving this logic to `__init__()` I think.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10598#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online