[tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

[Tor Bug Tracker & Wiki]

#13339: Merge GSoC project - Consensus Diffs
-----------------------------+-------------------------------------------
     Reporter:  mvdan        |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  major        |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  gsoc merge tor-client prop140
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------------

Comment (by mvdan):

 Thanks for pointing out that leak, tom. Will fix it.

 And great to see all those comments, dgoulet! :)

 Nick is right, I did notice I was using the deprecated method of testing
 but didn't look into it since it worked. I must have rebased against
 master some time later without noticing that the tests weren't compiling
 anymore. Will merge nickm's automated fix, thanks!

 Regarding the rest, I'll try having a set of commits out by tomorrow.

 One question though:

 > There are a lot of commits that could be squashed together here to make
 things easier. For instance, I'm thinking of from the older one up to when
 consdiff.c is created and consdiff_client/_server.c are deleted.

 I did think about this when doing rebases during the summer - of course
 the initial number of commits was much larger - but I was often unsure how
 to rewrite the history properly.

 For example, my reasoning behind leaving the old files there is that you
 can use git log/blame/etc with --follow to see where all the lines come
 from, without having a moderate chunk of code appearing from nowhere in
 consdiff.c. Or perhaps that is the best option?

 I will try to rebase stuff like the test fixes into each of the commits
 that added tests, of course. That'll probably be the sixth branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online