[tor-bugs] #12890 [Tor]: Design and implement optimizations for socket write limits

[Tor Bug Tracker & Wiki]

#12890: Design and implement optimizations for socket write limits
-----------------------------+--------------------------------
     Reporter:  robgjansen   |      Owner:  robgjansen
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay
Actual Points:               |  Parent ID:  #12541
       Points:               |
-----------------------------+--------------------------------

Comment (by nickm):

 > 1. I have attached a patch for a slight refactoring of the thread main
 loop

 looks good to me.

 > 2. and I think we don't want that!

 You mean, we don't want to have the buffer size get smaller and smaller
 forever?  Indeed, that sounds bad.

 > 3. It would be useful to have the global read/write limits feature there
 before starting to test. For now, this could be as simple as a
 configuration option that specifies the upstream link capacity, and then
 the logic necessary to enforce the limit.

 Don't we already have this?  I thought that BandwidthRate already enforced
 a global read/write limit.

 > 4. We probably also want to write a bit above the per-socket and/or
 global limits

 Will do.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12890#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online