[tor-bugs] #8864 [Tor]: Hidden service: Suddenly the service does not respond to new connections (INTRODUCE2 cell on intro circ with no corresponding rend_intro_point_t)

[Tor Bug Tracker & Wiki]

#8864: Hidden service: Suddenly the service does not respond to new connections
(INTRODUCE2 cell on intro circ with no corresponding rend_intro_point_t)
------------------------+---------------------------------------------
     Reporter:  reiam   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.???
    Component:  Tor     |    Version:  Tor: 0.2.3.25
   Resolution:          |   Keywords:  tor-hs 023-backport 025-triaged
Actual Points:          |  Parent ID:
       Points:          |
------------------------+---------------------------------------------

Comment (by asn):

 Replying to [comment:7 rransom]:
 > The `if (!node || !intro_circ) {` block in `rend_services_introduce`
 should be an `if (!intro_circ) {` block only.  If `node` is `NULL` and
 `intro_circ` is not, the client probably wants to (emit a log message and)
 close `intro_circ`.

 Hm, that might be a good idea. IIUC, in the case where the IP is not in
 the consensus anymore, the problem is that even though the
 `rend_intro_point_t` gets freed, the `intro_circ` stays up and can be used
 by clients. So a client with an old consensus will use that node and send
 an `INTRODUCE2` cell down the circuit that will trigger this warning.

 This seeeeeems plausible. However, I'm not sure if it's what causes the
 problem in `20130515115701.rar​`. The weird thing there is that the log
 message appears only a few seconds after the IPs get picked.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8864#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online