[tor-bugs] #9635 [Tor]: Tor clients warn when they use the wrong ntor onion key

[Tor Bug Tracker & Wiki]

#9635: Tor clients warn when they use the wrong ntor onion key
-------------------------+-------------------------------------------------
     Reporter:  bastik   |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:  Tor: unspecified
   Resolution:           |   Keywords:  spammy-warnings, tor-bridge
Actual Points:           |  026-triaged-1 025-backport nickm-patch
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by dgoulet):

 commit fb91d647acdf0560fc7479d72eeea52e4e6ff41d
 * circuit_finish_handshake() +1284: adding {{{log_warn(LD_BUG, "Couldn't
 initialize cpath crypto");}}} seems redondant because
 {{{circuit_init_cpath_crypto()}}} already has logging for every possible
 failure.

 * onion_skin_ntor_client_handshake() +291: So this means that if msg_out
 is NULL, there are no log at all. Seems reasonable for {{{bad & 4}}}
 because it was downgraded but {{{bad & 3}}} is still a warning thus should
 it be logged even if msg_out is NULL?

 The rest looks good to me! ACK.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9635#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online