[tor-bugs] #13079 [Tor Browser]: environment variable to skip TorButton control port verification

[Tor Bug Tracker & Wiki]

#13079: environment variable to skip TorButton control port verification
-------------------------+-------------------------------------------------
     Reporter:  proper   |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-torbutton,
  Browser                |  TorBrowserTeam201412R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:3 proper]:
 > Forget about the
 [https://trac.torproject.org/projects/tor/attachment/ticket/13079/0001-Bug-13078
 -environment-variable-to-skip-TorButton-con.patch older patch].
 >
 > The
 [https://trac.torproject.org/projects/tor/attachment/ticket/13079/0001-Bug-13078
 -environment-variable-to-skip-TorButton-con.2.patch new patch] is much
 saner.
 >
 > It makes the feature from #11722 accessible by the
 {{{TOR_SKIP_CONTROLPORTTEST}}} variable. Tested by me. Both
 {{{TOR_SKIP_CONTROLPORTTEST}}} and the pref
 {{{extensions.torbutton.local_tor_check}}} still working.
 >
 > Please review.

 The patch looks OK.  The only question I have is whether we should check
 for a value of "1" in the TOR_SKIP_CONTROLPORTTEST env variable (rather
 than just checking for existence).  In Tor Launcher, we use "1" !=
 environ.get(...) tests, although I see one place in Torbutton where we
 just check for existence (search for TOR_TRANSPROXY within src/components
 /startup-observer.js to find it).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13079#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online