[tor-bugs] #13667 [Tor]: Prevent port scanning of hidden services

[Tor Bug Tracker & Wiki]

#13667: Prevent port scanning of hidden services
------------------------+------------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorR tor-hs 025-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------------

Comment (by dgoulet):

 Hrm on second thought, connection_exit_begin_conn() specifies that it
 should return a negative reason if we want the caller to close the
 circuit. However, fun fact, END_CIRC_REASON_NONE == 0 and closing the
 circuit right in that function is actually against the "rule" ... Thus
 returning "END_CIRC_AT_ORIGIN" could be more appropriate since it's value
 is -1.

 IMO, this function should close the circuit itself on error or, for some
 reason, if we don't want that, set explicitely an err. reason in a
 variable and return -1 if we want the circuit to be closed. The NONE
 reason is 0 and also a valid reason to actually close a circuit. I don't
 see any palces where we send back a NONE and want to close the circuit but
 it's error prone in the long run...

 Thoughts?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13667#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online